Re: Automatically responding to accepted additions to the SPDX License List
Dear Alexios,
Thanks for your feedback! My understanding of the new license addition
process was that the issue where the addition was requested would only
be closed after the associated PR was merged (which would happen
automatically if the PR author wrote "Resolves issue #xxx" in the PR
description). As such, my automation would only respond to closed
issues.
The whole process would be:
1: user creates an issue requesting the license addition
2: it's labelled as either accepted or declined
3: if it's accepted, a PR is created by someone
4: after PR is merged, the issue is closed
5: the script would automatically comment
Hope this explains it; let me know if I forgot something!
Best wishes,
Sebastian
toggle quoted message
Show quoted text
Thanks for your feedback! My understanding of the new license addition
process was that the issue where the addition was requested would only
be closed after the associated PR was merged (which would happen
automatically if the PR author wrote "Resolves issue #xxx" in the PR
description). As such, my automation would only respond to closed
issues.
The whole process would be:
1: user creates an issue requesting the license addition
2: it's labelled as either accepted or declined
3: if it's accepted, a PR is created by someone
4: after PR is merged, the issue is closed
5: the script would automatically comment
Hope this explains it; let me know if I forgot something!
Best wishes,
Sebastian
On Thu, Aug 25, 2022 at 06:56:58AM +0000, Alexios Zavras wrote:
Nice automation work, Sebastian!
I'm probably missing something, but...
The review and the labeling as "accepted" is happening on the issue where someone submits a new license.
In order to have "the license's information added to the repository", we also need a PR with the license XML, test file, etc.
How is this handled?
I definitely remember cases in the past where licenses were accepted and then we had to wait a long time for a PR (or Steve usually went ahead and created one).
-- zvr
-----Original Message-----
From: Spdx-legal@... <Spdx-legal@...> On Behalf Of Sebastian Crane
Sent: Thursday, 25 August, 2022 00:30
To: SPDX Legal Mailing List <spdx-legal@...>
Subject: Automatically responding to accepted additions to the SPDX License List
Dear all,
I have good news! I've been able to create a CI workflow which responds to accepted license requests on GitHub automatically, letting everyone know that the license won't be visible on the website until the next release.
Attached is a screenshot from a test repository of mine, where I've simulated opening, labelling as accepted, then closing a 'New License Request' issue. To prevent it from running repeatedly, the workflow adds a 'finalised' label which it checks for before commenting. Let me know what you think of the wording and we can get this running for real!
Best wishes,
Sebastian
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928