Re: SPDX files as templates
toggle quoted message Show quoted text
Previously I've been generally against the idea of encouraging folks to use the test/simpleTestForGenerator/*.txt files for anything other than the automated tests for the XML files. Mostly for the reason you noted at the start of this thread: that in many cases (especially where a copyright notice is baked into the license text, such as MIT) people may grab it without realizing they should probably adjust the text.
I've been pretty well convinced that I was wrong there; if people are finding value in using the "test" text as license templates, then great.
A couple of random thoughts, getting into the weeds:
1) People should not assume that the text in test/simpleTestForGenerator/*.txt is necessarily the _official, canonical, byte-for-byte text_ from the license steward, if there is one. Here are a couple of examples:
* https://github.com/spdx/license-list-XML/blob/master/test/simpleTestForGenerator/Apache-2.0.txt is different from https://www.apache.org/licenses/LICENSE-2.0.txt (at least w/r/t whitespace; I haven't checked more closely)
* https://github.com/spdx/license-list-XML/blob/master/test/simpleTestForGenerator/GPL-2.0-or-later.txt is different from https://www.gnu.org/licenses/old-licenses/gpl-2.0.txt (at least w/r/t whitespace, and different parts of "optional" text after the end of the license, etc).
There's a related question of whether the test text in the license-list-XML repo _should_ be the same as the canonical license steward text, where there is one. I'm just noting that at present, it isn't always the same. Also, since license stewards sometimes make changes to their own official license texts (GPL-2.0 is an example), the SPDX text is not necessarily going to be in sync if upstream makes a change.
2) I'd tend to agree that it's generally going to be preferable to point folks at the text/ directory in the license-list-data repo. That helps to keep the concerns separated as "go to license-list-data if you're a user of the License List; go to license-list-XML in order to contribute."
From a very quick skim, it looks like the text/ directory in license-list-data is _mostly_ the same as the test text files in license-list-XML. I see a handful with differences in whitespaces; and it looks like the naming for deprecated licenses might be handled differently. But those are both presumably something that could be addressed.
On Tue, Nov 16, 2021 at 3:46 PM J Lovejoy <opensource@...> wrote: